Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛃 Chat permission API + Web #7235

Merged
merged 7 commits into from
Apr 29, 2022
Merged

🛃 Chat permission API + Web #7235

merged 7 commits into from
Apr 29, 2022

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Apr 27, 2022 •
edited
Loading

  • Based on Allow to get Reactions summary and media tab in read-only rooms #7234
  • 🛠️ Limit posting
    • 🖌️ Remove or disable UI option
    • 🦺 Integration test
  • 🛠️ Limit deleting message
    • 🖌️ Remove or disable UI option
    • 🦺 Integration test
  • 🛠️ Limit reacting
    • 🖌️ Remove or disable UI option
    • 🦺 Integration test
  • 🛠️ Limit removing reaction
    • 🖌️ Remove or disable UI option
    • 🦺 Integration test
  • 🛠️ Limit sharing object
    • 🖌️ Remove or disable UI option
    • 🦺 Integration test
  • 🛠️ Limit voice recording
    • 🖌️ Remove or disable UI option
    • 🦺 Integration test
  • 🛠️ Limit sharing files to the conversation
    • 🖌️ Remove or disable UI option
    • 🦺 Integration test
  • 🛠️ Limit sharing files to the conversation via the files sharing app
    • 🖌️ Remove or disable UI option
    • 🦺 Integration test
  • 🛠️ Allow to set and remove the chat permission
    • 🖌️ Add UI option
    • 🦺 Integration test

Questions

  • We need to update all existing permissions adding the 128?
  • Current "Restricted" quick option should still allow chatting as until now, or be "only passive permissions" as until now?
  • Do we need mobile client support before we can merge this?

Fix #3886

@nickvergessen nickvergessen added 2. developing feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Apr 27, 2022
@nickvergessen nickvergessen added this to the 💚 Next Major (25) milestone Apr 27, 2022
@nickvergessen nickvergessen self-assigned this Apr 27, 2022
@nickvergessen
Introduce a chat permission on the API
7c1268a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feature/noid/chat-permission branch 2 times, most recently from 49b342a to 463146a Compare April 27, 2022 19:19
@nickvergessen
Disable UI elements which can not be used anymore
f810f17 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add an option to grant/remove chat permissions
7f0dbc0 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Disallow sharing without chat permissions
5874253 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add a capability for the permission
951378c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add a migration to update existing permissions
aa5d764 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Update baseline as the interface will die soon anyway it makes little…
3135b47 
… sense to add the method

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen marked this pull request as ready for review April 27, 2022 19:23
@nickvergessen nickvergessen changed the title Chat permission 🛃 Chat permission Apr 27, 2022
This was referenced Apr 29, 2022
Closed
Closed
@nickvergessen nickvergessen merged commit 51f2959 into master Apr 29, 2022
@nickvergessen nickvergessen deleted the feature/noid/chat-permission branch April 29, 2022 06:56
@nickvergessen nickvergessen changed the title 🛃 Chat permission 🛃 Chat permission API + Web May 11, 2022
@nickvergessen nickvergessen mentioned this pull request May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitormattos vitormattos vitormattos approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@danxuliu danxuliu Awaiting requested review from danxuliu

@nikola-gladovic nikola-gladovic Awaiting requested review from nikola-gladovic

Assignees

@nickvergessen nickvergessen

Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
💬 Talk team
Archived in project
Milestone
v15.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

🛂 Chat permission
2 participants
@nickvergessen @vitormattos