Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6927: updated button for NewGroupConversation #6949

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

nikola-gladovic
Copy link
Contributor

Signed-off-by: Nikola nikola.gladovic@nextcloud.com

#6927

Signed-off-by: Nikola <nikola.gladovic@nextcloud.com>
Signed-off-by: Nikola <nikola.gladovic@nextcloud.com>
@nickvergessen
Copy link
Member

nickvergessen commented Mar 4, 2022

@marcoambrosini you requested the class removal, but now e.g. the "Add participants" button jumps from left to right when ticking the checkbox for "Allow guests"

Without guests With guests
Bildschirmfoto von 2022-03-04 10-48-51 Bildschirmfoto von 2022-03-04 10-48-54

I think we should fixate the side of the buttons again.

Also the close button on the final step is now on the left, so you can't click "through" anymore as the last step has the button on the other corner again

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the order of the buttons in the flexbox is not right

Screenshot 2022-03-07 at 18 16 38

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: approving since it's not related with this pr

@marcoambrosini marcoambrosini merged commit e0f4228 into master Mar 7, 2022
@marcoambrosini marcoambrosini deleted the feat/6927/button-for-new-group-conversation branch March 7, 2022 17:20
@nickvergessen
Copy link
Member

@marcoambrosini you saw my comment about the jumping buttons?

@danxuliu
Copy link
Member

danxuliu commented Mar 7, 2022

The following error appears in the browser console when opening the main Talk UI as a registered user since this pull request was merged:

[Vue warn]: Error in data(): "TypeError: this.$slots.default[0].text is undefined"

found in

---> <Button>
       <NewGroupConversation> at src/components/LeftSidebar/NewGroupConversation/NewGroupConversation.vue
         <AppNavigation>
           <LeftSidebar> at src/components/LeftSidebar/LeftSidebar.vue
             <Content>
               <App> at src/App.vue
                 <Root>

I guess it is caused by the icon-only button to create a new conversation (but I have not checked that).

@nickvergessen
Copy link
Member

Fixed upstream at nextcloud-libraries/nextcloud-vue#2540

@nickvergessen nickvergessen added this to the 💛 Next Major (24) milestone Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants