-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6927: updated button for NewGroupConversation #6949
6927: updated button for NewGroupConversation #6949
Conversation
Signed-off-by: Nikola <nikola.gladovic@nextcloud.com>
src/components/LeftSidebar/NewGroupConversation/NewGroupConversation.vue
Outdated
Show resolved
Hide resolved
src/components/LeftSidebar/NewGroupConversation/NewGroupConversation.vue
Outdated
Show resolved
Hide resolved
src/components/LeftSidebar/NewGroupConversation/NewGroupConversation.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: Nikola <nikola.gladovic@nextcloud.com>
@marcoambrosini you requested the class removal, but now e.g. the "Add participants" button jumps from left to right when ticking the checkbox for "Allow guests"
I think we should fixate the side of the buttons again. Also the close button on the final step is now on the left, so you can't click "through" anymore as the last step has the button on the other corner again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit: approving since it's not related with this pr
@marcoambrosini you saw my comment about the jumping buttons? |
The following error appears in the browser console when opening the main Talk UI as a registered user since this pull request was merged:
I guess it is caused by the icon-only button to create a new conversation (but I have not checked that). |
Fixed upstream at nextcloud-libraries/nextcloud-vue#2540 |
Signed-off-by: Nikola nikola.gladovic@nextcloud.com
#6927