-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Techdebt/noid/node14 npm7 #5773
Conversation
@nickvergessen thanks for the suggestions. I already changed this in parallel, strange that Github doesn't say anything about this. Now the errors are about actual code to adjust to satisfy eslint |
@marcoambrosini the jest stuff is fixed as you asked, do you want to take care of the reported eslint issues ? |
Thanks @PVince81, yes I will! |
We talked about it with skjnldsv yesterday and it might also be okay to add a temporary exception to the eslint as it's just a different prefered coding style |
Yes, requires investigation though, this is an error, not a warning 😁 |
Should be a super easy fix, on it |
c26e11d
to
b3978a4
Compare
Ok it should™ all be good now, reviews plz! |
b3978a4
to
aa22cdb
Compare
aa22cdb
to
0dc7284
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to break calls completely
- can't see my own video
- sharing the screen doesn't work anymore
[Vue warn]: Error in callback for watcher "localMediaModel.attributes.localStream": "TypeError: adapter.browserDetails is undefined"
found in
---> <LocalVideo> at src/components/CallView/shared/LocalVideo.vue
<Grid> at src/components/CallView/Grid/Grid.vue
<CallView> at src/components/CallView/CallView.vue
<MainView> at src/views/MainView.vue
<AppContent>
<Content>
<App> at src/App.vue
<Root> vue.runtime.esm.js:619
TypeError: adapter.browserDetails is undefined
exports attachmediastream.js:41
_setLocalStream LocalVideo.vue:261
localStream LocalVideo.vue:203
VueJS 5
0dc7284
to
29f4e1a
Compare
This reverts commit 5b75002.
This reverts commit 35be040.
This reverts commit e43077f.
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
29f4e1a
to
da3d3e3
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Tested with:
|
|
||
// Toggles videos on and off | ||
handleToggleVideo({ peerId, value }) { | ||
this.sharedDatas[peerId].videoEnabled = value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref nextcloud/app-tutorial#319 (comment)