Improve tab header styles, center headings, flexbox #568
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
|
There are some troubles with chat tab:
|
|
For me when the chat is active, the lines are *** up: |
|
Seems like a caching issue for both of you? Looks fine here in any case. |
|
Only happens in Chrome |
| opacity: 1; | ||
| } | ||
|
|
||
| #tabHeaderChat { | ||
| #tabHeaderChat a { | ||
| background-image: url('../../../core/img/actions/comment.svg?v=1'); |
There was a problem hiding this comment.
Btw this breaks when apps are not installed in an app folder in root,
Should fix for 3.1
There was a problem hiding this comment.
Yep, I only used it because it was already used in the code – by you ;)
https://github.com/nextcloud/spreed/blame/93e0a82f2e91537941c56b1cb31f29e9e4a9338e/css/style.scss#L906
But yes – the reason why I needed to use it like that is because I needed to insert a class (.icon-comment in this case) into the tabHeader, or rather the link inside of it. If we can do that in the code rather, we don’t need that CSS.
Right, here Firefox is fine and Chromium broken. Besides that the icon and name are not (perfectly) centered on the tab header. Is that intended? |
|
@danxuliu @nickvergessen hmm, in Chromium I get a »Error while accessing microphone & camera«. Is that because of non-https on localhost? If so, I need instructions to set that up as the former attempts have not succeeded. :\ And they should be in the README as Developer setup. |
I doubt it; I am using it with HTTP on localhost without problems. |
|
@jancborchardt Yes, in Chromium https is needed to access camera and mic. |
Interesting, maybe it's just for camera permissions? I remember you don't have any camera, right? |
Right.
By not having a camera, it seems :-P |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
|
Haha, ok I have a camera killswitch on my Purism laptop :D Comes in very handy cause it works now! And fixed the issue with Chrome/Chromium too. :) |
Before / after:
More breathing space, 50% default width for the tabs, proper underline for inactive tab.
Please review @nextcloud/talk