Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct reply button in message row #5302

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Direct reply button in message row #5302

merged 2 commits into from
Mar 4, 2021

Conversation

PVince81
Copy link
Member

@PVince81 PVince81 commented Mar 3, 2021

Moved reply button outside the actions menu in the message row.
This way it is quicker for the user to find and click.

Fixes #5297

Regular row:
image

Tall row:
image

As menu:
image

@PVince81
Direct reply button in message row
5ff1981 
Moved reply button outside the actions menu in the message row.
This way it is quicker for the user to find and click.

Also fixes hasActions to also include third party message actions for
making the menu visible. The latter worked before only by chance.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 added this to the 💖 Next Major (22) milestone Mar 3, 2021
@PVince81 PVince81 self-assigned this Mar 3, 2021
@PVince81 PVince81 mentioned this pull request Mar 3, 2021
Closed
jakobroehrl
jakobroehrl approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@jakobroehrl jakobroehrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@nickvergessen
Copy link
Member

So when delete is the only option, can we still put it in a ... menu?
I think otherwise the immediately visible red icon is way to alerting

@PVince81 @nickvergessen
Force menu in message row
b19eef1 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
@PVince81
Copy link
Member Author

PVince81 commented Mar 4, 2021

So when delete is the only option, can we still put it in a ... menu?
I think otherwise the immediately visible red icon is way to alerting

Makes sense. That bit also disturbed me and I wasn't sure. At least it will prevent accidental clicks.

Committed, please review.

@PVince81 PVince81 merged commit de3cd73 into master Mar 4, 2021
@PVince81 PVince81 deleted the enh/5297/message-direct-reply-button branch March 4, 2021 08:45
@PVince81
Copy link
Member Author

/backport to stable21.1

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobroehrl jakobroehrl jakobroehrl approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@PVince81 PVince81

Labels
3. to review enhancement feature: chat 💬 Chat and system messages
Projects
None yet
Milestone
v12.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

Give direct access to replying
3 participants
@PVince81 @nickvergessen @jakobroehrl