-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy msg link to clipboard #5285
Conversation
So with more and more actions (delete, deck-integration, reply-private, copy link) I think the most used action (reply) is getting moved to far away as you always need to open the ... first. |
2d8edd0
to
e848207
Compare
we probably need a second button just for replying. |
@nickvergessen Thought exactly the same, yep.
@PVince81 exactly that – just like we do in files too, or e.g. in the left navigation of calendar, in both cases where "Share" is a direct action. In this case "Reply" will be the direct action, and everything else is details. |
Agree, should we create a separate ticket for this? |
yeah, it shouldn't block a "random" pr adding another action |
Reported #5297 |
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
e848207
to
3ae9588
Compare
nice! I'm starting to wonder if we should start to add some separators in there, maybe to separate the hard-coded actions from the registered ones. @ma12-co any thoughts on this ? (see above screenshot) |
Yep, we could have something like:
|
@jakobroehrl do you want to take care of the separators or is this something for another PR ? note: there are like more actions coming |
I will try the seperators here in this PR Could you say me the actions, maybe I can help with the easy ones? |
I have a PR that will bring "mark as unread" here later on: #3825. |
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
@jakobroehrl I already created the action there, thanks :-) The only thing you can do right now is add the separators as @ma12-co advised. I'd say put them in this PR here. |
okay, you added already. let me review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @jakobroehrl :)
One question, I'm not able to copy links of my own messages, I think it would be nice to be able to do so too. Is there a particular reason why this wasn't implemented?
As a side note, I also think that we should use var(--color-primary-light) for the fading feedback on the target message to give some more emphasis and differentiate it from the messages hover/focus feedbacks.
Thanks! :)
Sorry, what do you mean here? What exactly should I change? |
Noice :)
Basically those 3 variables in the animation into |
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
e5bed92
to
22da040
Compare
Signed-off-by: Jakob Röhrl jakob.roehrl@web.de
solves: #5097