conversation state: Only Moderators can write

[jakobroehrl]

Signed-off-by: Jakob Röhrl jakob.roehrl@web.de
solves: #3886

[PVince81]

• increase the field width

@ma12-co or replace it with something similar-looking like the notifications ?

• please adjust the status messages on frontend and backend and their matching backend tests
• please search for "readonly" on the server side, there are various places to extend like for example the occ commands to allow setting the new flag, for example https://github.com/nextcloud/spreed/blob/enh/limitWritingToMods/lib/Command/Room/Create.php#L108 (there's more!)

[PVince81]

• bug: the reply and delete options are still visible in the menu even when I can't post (could be a separate bug that existed before)

[PVince81]

• adjust read-only state check in backend:
  • https://github.com/nextcloud/spreed/blob/enh/limitWritingToMods/lib/Middleware/InjectionMiddleware.php#L174 (see https://github.com/nextcloud/spreed/blob/enh/limitWritingToMods/lib/Middleware/InjectionMiddleware.php#L139 for code for checking moderator state).
  • I'd also recommend renaming the method to adjust its updated semantics

[PVince81]

• please search for "readonly" on the server side, there are various places to extend like for example the occ commands to allow setting the new flag

How to change it here? @PVince81

1. https://github.com/nextcloud/spreed/blob/master/lib/Command/Room/TRoomCommand.php#L149

2. https://github.com/nextcloud/spreed/blob/master/lib/Command/Room/Update.php#L102

For 1. change the boolean to int and check where the function is called.

For 2, that line is for validating the occ command input. Just add the new constant you introduced into the array.

[PVince81]

please also change the next line, you need to compare the int value now

[PVince81]

please recheck the whole function, it needs to be rewritten to handle the int value as it's not a bool any more

[PVince81]

Further locations I've found by grepping variations of "readOnly", "read-only", "read_only" that will need adjusting:

• system messages:

  • https://github.com/nextcloud/spreed/blob/enh/limitWritingToMods/lib/Chat/SystemMessage/Listener.php#L175
  • https://github.com/nextcloud/spreed/blob/enh/limitWritingToMods/lib/Chat/Parser/SystemMessage.php#L156

• let mods add shares to rooms when readOnly==2: https://github.com/nextcloud/spreed/blob/enh/limitWritingToMods/lib/Collaboration/Collaborators/RoomPlugin.php#L63

• fix occ flag update: https://github.com/nextcloud/spreed/blob/enh/limitWritingToMods/lib/Command/Room/Update.php#L143

• occ autocomplete: https://github.com/nextcloud/spreed/blob/enh/limitWritingToMods/lib/Command/Room/Update.php#L174

• adjust middleware to check for moderator: https://github.com/nextcloud/spreed/blob/enh/limitWritingToMods/lib/Middleware/InjectionMiddleware.php#L172

• add moderator check:

  • https://github.com/nextcloud/spreed/blob/enh/limitWritingToMods/lib/Share/RoomShareProvider.php#L171

• allow mods to have a call ? https://github.com/nextcloud/spreed/blob/enh/limitWritingToMods/src/components/TopBar/CallButton.vue#L160

• flow: allow mods' flow plugin to post to mod-restricted rooms: https://github.com/nextcloud/spreed/blob/enh/limitWritingToMods/src/views/FlowPostToConversation.vue#L82

• RoomSelector (available from Deck app): not sure if we can easily check for mod status here, probably ok to leave as is: https://github.com/nextcloud/spreed/blob/enh/limitWritingToMods/src/views/RoomSelector.vue#L99

• notify mobile devs so they can implement the same client side logic

• add new capability entry + docs?

• update docs, see docs/constants.md

• integration tests

[nickvergessen]

Turning into a draft for the open points to have the review/to merge list cleaner

[nickvergessen]

@jakobroehrl any chance you want to continue on this?

[jakobroehrl]

@jakobroehrl any chance you want to continue on this?

I don't think so, sorry. It's a little bit to deep into PHP. Maybe you can do it? and I support? Or we just close it?

[nickvergessen]

I will close the PR for now. Anyone can pick it up whenever they want and reopen the PR.