[stable21.1] Prevent loading old messages twice on scroll #5209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://github.com/avatars/in/21012?s=60&v=4){kind=small}
Whenever the old messages are already loading initially when opening a conversation, a scroll event might call getOldMessages again which would cancel the previous one. The initial old messages load is using includeLastKnown=1 while the others use 0. So if it gets cancelled, we will miss the "last known" message as it won't be included in subsequent calls. This fix prevents repeated calls to getOldMessages to avoid the above issue. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
backportbot-nextcloud
bot
requested review from
danxuliu,
marcoambrosini,
nickvergessen and
PVince81
nickvergessen
approved these changes
Feb 19, 2021
nickvergessen
added
4. to release
feature: chat 💬
This was referenced Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #5198