-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow other apps to register message actions #5019
Allow other apps to register message actions #5019
Conversation
1914498
to
5318d57
Compare
5318d57
to
d54da5e
Compare
So I used: window.OCA.Talk.registerMessageAction({
label: 'test',
callback: (messageAPIData) => console.log(messageAPIData),
icon: 'icon-reply',
}) but the icon is still black on dark mode. I guess there is some specialty required to stop the auto-invert of something as it might happen twice (action inverts it and the img is actually already inverted) |
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
hmm, this is a weird one, this happens with the original reply button too. And it seems to disappear only on hover. Anyhow seems it's not related to this pr as it's reproducible on master |
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
d54da5e
to
e75bee7
Compare
Tested and works with me WIP implementation 👍 |
/backport to stable21.1 |
How to test:
Open a message 3 dot menu;
Click on the added action;
Check if the response object is logged in the console
Signed-off-by: Marco Ambrosini marcoambrosini@pm.me