Cannot disable sip #4951
Merged
Cannot disable sip #4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
bug
feature: settings ⚙️
|
/backport to stable20.1 |
because they grew from some initial confusion and eventually it seems I only adjusted a single one later on |
|
Which is good and which is bad? so I can use either and do a string replace? |
|
The backport to stable20.1 failed. Please do this backport manually. |
I don't remember. But one of them might not properly reset the checkbox state in case of error. |
|
I had some WIP for error handling and trying to reset the states here: #4671 |
|
Seems this is only broken in 21, works fine in 20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🙈 I wonder why
LockingSettings.vueandSipSettings.vueare so different when they do the same thing :D