[stable19] Fix user management in password request rooms #4797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
Until now it was possible to verify the room data when getting the full room list with the "user is participant of the following rooms" step. Now the same can be optionally done when using "user is participant of room XXX" too. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
This fixes a regression introduced in 4afa2d7. The active guests are only those who are currently in a call, and not those who are currently in the conversation. Therefore other guests or users were not prevented from joining a password request conversation if a guest was in the conversation but not in the call. Fortunately in practice this was not a problem, as the Web UI starts a call immediately after joining the conversation, which made the guest immediately active and thus prevented others from joining. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Only the owner and another participant will be allowed to join a password request room, so there is no point in being able to add more participants to those rooms. Although throwing the exception in the listener is enough to prevent adding the participants unhandled exceptions in the endpoint are returned as error 404, but the expected error would be 400. To minimize conflicts with other pull requests and backports it is explicitly checked if the room is a password request room instead of refactoring the code to handle the exception. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
approved these changes
Dec 18, 2020
nickvergessen
deleted the
backport/4656/stable19-fix-user-management-in-password-request-rooms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4656