Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests use occ guests:add to create guests #4764

Merged
merged 2 commits into from
Dec 18, 2020

Conversation

PVince81
Copy link
Member

@PVince81 PVince81 commented Dec 15, 2020

Removed cheat that used GuestManager directly from the guests app.
Now using occ guests:add to create guest account users.

@PVince81
Copy link
Member Author

I ran this locally and it worked

Removed cheat that used GuestManager directly from the guests app.
Now using occ guests:add to create guest account users.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 force-pushed the techdebt/noid/guests-use-occ-no-cheating branch from d9a0ae7 to fffa965 Compare December 18, 2020 15:07
@PVince81
Copy link
Member Author

guests PR was merged.
rebased to retrigger CI, expecting green now

@PVince81 PVince81 marked this pull request as ready for review December 18, 2020 15:07
@nickvergessen nickvergessen merged commit e562a12 into master Dec 18, 2020
@nickvergessen nickvergessen deleted the techdebt/noid/guests-use-occ-no-cheating branch December 18, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants