Cancel search while typing #4742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 tasks
|
Sounds like a good idea |
The search requests in the left sidebar, new conversation dialog and participants tab are now cancellable. They cancel either when the user continues to type or when exiting or destroying the component. This should help reduce the load on servers while people are searching. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
force-pushed
the
enh/noid/cancel-search-while-typing
branch
from
df2819e
to
235f5d9
Compare
PVince81
commented
Dec 14, 2020
| const searchListedConversations = async function(searchTerm) { | ||
| const response = await axios.get(generateOcsUrl('apps/spreed/api/v3', 2) + 'listed-room', { | ||
| const searchListedConversations = async function(searchTerm, options) { | ||
| return axios.get(generateOcsUrl('apps/spreed/api/v3', 2) + 'listed-room', Object.assign(options, { |
There was a problem hiding this comment.
note: await is gone because redundant (if you leave it here eslint will warn about it)
nickvergessen
approved these changes
Dec 15, 2020
|
I was so focused on testing the cancellability that I forgot to test if the search actually works. A copy-paste issue had sneaked in, fixed here: #4835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is in the very last commit if you want to have a peek.