Create a new table for internal signaling and guest names with a PK

[nickvergessen]

Signed-off-by: Joas Schilling coding@schilljs.com

[PVince81]

@nickvergessen mind adding more context to the PR to explain what this is about and why we need it ? (our future selves will be thankful)

[PVince81]

aha, the branch name contains a clue "cluster-compatibility"

[nickvergessen]

Yeah, so tables need a primary key in order to work in Galera and other clusters:
https://mariadb.com/kb/en/mariadb-galera-cluster-known-limitations/

All tables should have a primary key (multi-column primary keys are supported). DELETE operations are unsupported on tables without a primary key. Also, rows in tables without a primary key may appear in a different order on different nodes.

Server was fixed in nextcloud/server@d5df033#diff-723d474847ce3f8926be66be2147d580e43f9a021655b56b6942d683ed408b49

[PVince81]

👍 looks fine, see minor comment.

I did a quick test with some data in the table and the guest names were moved properly to the new table.

[PVince81]

there's a chat integration test that failed, maybe rebase to try again

[nickvergessen]

It was actually a valid fail for inserting a guest name.

[PVince81]

👍 nice catch