Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable20] Update nextcloud-vue from 2.6.8 to 2.8.2 to fix emoji picker performance issue #4514

Merged
merged 3 commits into from
Nov 2, 2020
Merged

[stable20] Update nextcloud-vue from 2.6.8 to 2.8.2 to fix emoji picker performance issue #4514

merged 3 commits into from
Nov 2, 2020

Conversation

PVince81
Copy link
Member

@PVince81 PVince81 commented Nov 2, 2020 •
edited
Loading

Fixes #4501

Brings in:

Regression testing:

  • smoke test dialogs, like settings
  • smoke test emoji picker
  • app sidebar padding / scrolling / loading state

Test for additions:

  • energy impact low
  • avatar caching works: no more flickering

@PVince81
Update nextcloud-vue to 2.6.8
01f6f13 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 added this to the 💛 Next Minor (20) milestone Nov 2, 2020
@PVince81 PVince81 self-assigned this Nov 2, 2020
@PVince81 PVince81 mentioned this pull request Nov 2, 2020
Closed
@PVince81
Cache hasAvatar to avoid call background flickering
5b34220 
Whenever the speaker changes, the avatar background can flicker due to
HTTP calls. This fix improves it a bit by caching the information
whether the user has an avatar or not, so allows a less delayed loading of
the avatar background.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Use browser storage for hasAvatar state
a7db1b1 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Copy link
Member Author

PVince81 commented Nov 2, 2020

I'm adding a backport of #4379 as it goes hand in hand with the avatar caching and I anyway need to retest this bit.

@PVince81 PVince81 mentioned this pull request Nov 2, 2020
Merged
@PVince81
Copy link
Member Author

PVince81 commented Nov 2, 2020

I've tested and all seems to work fine.

Before merging let's wait at least for the master counterpart to be merged first: #4513

@marcoambrosini marcoambrosini merged commit 15dce32 into stable20 Nov 2, 2020
@marcoambrosini marcoambrosini deleted the bugfix/4501/update-nc-vue-2/stable20 branch November 2, 2020 14:51
@nickvergessen nickvergessen changed the title [stable20] Update nextcloud-vue from 2.6.8 to 2.8.2 [stable20] Update nextcloud-vue from 2.6.8 to 2.8.2 to fix emoji picker performance issue Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@PVince81 PVince81

Labels
3. to review
Projects
None yet
Milestone
v10.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@PVince81 @skjnldsv @marcoambrosini