Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix guest entries in sidebar #410

Merged
merged 4 commits into from
Sep 20, 2017
Merged

Fix guest entries in sidebar #410

merged 4 commits into from
Sep 20, 2017

Conversation

nickvergessen
Copy link
Member

Fix #408
Partly #399

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants labels Sep 19, 2017
@nickvergessen nickvergessen added this to the 3.0 (Nextcloud 13) milestone Sep 19, 2017
@nickvergessen nickvergessen mentioned this pull request Sep 19, 2017
6 tasks
@codecov
Copy link

codecov bot commented Sep 19, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@815c509). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #410   +/-   ##
=========================================
  Coverage          ?   11.45%           
  Complexity        ?      369           
=========================================
  Files             ?       24           
  Lines             ?     1764           
  Branches          ?        0           
=========================================
  Hits              ?      202           
  Misses            ?     1562           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
appinfo/routes.php 0% <0%> (ø) 0 <0> (?)
lib/Room.php 0% <0%> (ø) 46 <5> (?)
lib/Controller/RoomController.php 0% <0%> (ø) 105 <6> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 815c509...bcbc315. Read the comment docs.

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@nickvergessen
Copy link
Member Author

👍 for your commit ivan

@nickvergessen
Copy link
Member Author

I just noticed, that when a guest set a name, they get a colored avatar, but the name doesn't show in the sidebar and the avatar is still grey...
@Ivansss where is this info stored and is it accessible somehow?

@Ivansss Ivansss merged commit e185152 into master Sep 20, 2017
@Ivansss Ivansss deleted the fix-guest-entries-in-sidebar branch September 20, 2017 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants