Start with sidebar

[nickvergessen]

[codecov]

Codecov Report

Merging #377 into master will decrease coverage by 0.22%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #377      +/-   ##
============================================
- Coverage     12.28%   12.06%   -0.23%     
- Complexity      343      348       +5     
============================================
  Files            22       22              
  Lines          1644     1674      +30     
============================================
  Hits            202      202              
- Misses         1442     1472      +30

Impacted Files	Coverage Δ	Complexity Δ
lib/Controller/RoomController.php	0% <0%> (ø)	99 <5> (+5)	⬆️
appinfo/routes.php	0% <0%> (ø)	0 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68ff6bd...1ffa4e0. Read the comment docs.

[jancborchardt]

Ah so the Chat should also be in this sidebar then, right?

[nickvergessen]

I don't care about chat until it is here. Currently it holds only moderation features, so I would only show it for moderators. But we can change that in the future, once chat is there.
I guess it would just be another tab view then...

[jancborchardt]

I made some changes, however they are not taken into account since the file https://github.com/nextcloud/server/blob/master/apps/files_sharing/css/sharetabview.scss is not loaded in this app it seems. Can we make that happen somehow? A simple @import '../../files_sharing/css/sharetabview.scss'; did not work because of:
The resource from “http://localhost/nextcloud/apps/files_sharing/css/sharetabview.scss” was blocked due to MIME type mismatch (X-Content-Type-Options: nosniff).

Regarding the other things:

• Some marker for User is currently in this call

Sort the people currently in this call up top. People not in the call should additionally be half-transparent. Give the li element of participants not in the call the class .participant-offline and the CSS I added will display them accordingly. (See the example code I added.)

Some marker for User is a moderator/owner

Sort them at the very top (even if offline), give the li element of moderators the class .participant-moderator and put a (moderator) behind their name in a span called .participant-moderator-indicator. (See the example code I added.)

Some further questions:

• What does the "start/stop webinar" button exactly do?
• I guess we should move the actions from the left sidebar (Add person, Rename, Share link, Delete call) fully to the sidebar? And the 3-dot button will open the sidebar. Otherwise there will be duplication.

[nickvergessen]

Can you commit the sharetabview.scss then I can do the import

[nickvergessen]

What does the "start/stop webinar" button exactly do?

It's the schedules call feature from: #347 (comment)

I guess we should move the actions from the left sidebar (Add person, Rename, Share link, Delete call) fully to the sidebar? And the 3-dot button will open the sidebar. Otherwise there will be duplication.

I thought the same, but then you can not leave/delete rooms without having to join them. The three dot is available while you are in a different room/call. The sidebar is not. Also as said before, currently the side bar is moderators only. For normal users it would be pretty empty, or would you show the user list there too?

[jancborchardt]

@nickvergessen you mean just duplicate the sharetabview.scss here? Is there no way to call the original?

[nickvergessen]

I would just copy the necessary elements to a new file. Depending on another app is never a good idea.

[jancborchardt]

I'll move sharetabview to core then cause we shouldn't copypaste stuff all over.

[nickvergessen]

@Ivansss can you review this first step?

I will then create a new issue for the remaining tasks

[nickvergessen]

Remaining todos: #399

[nickvergessen]

@Ivansss ping 🏓

[Ivansss]

Guests have no avatar and no name in the sidebar.