Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable17] Do not remove other event handlers when setting the active room #2230

Merged
merged 2 commits into from
Sep 27, 2019
Merged

[stable17] Do not remove other event handlers when setting the active room #2230

merged 2 commits into from
Sep 27, 2019

Commits on Sep 26, 2019

  1. Extract handler to update the page title on display name change 

    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu
    danxuliu authored and Backportbot committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    fb5b88f View commit details
    Browse the repository at this point in the history

  2. Do not remove other event handlers when setting the active room 

    Besides being more correct, this also fixes the participant list not
shown for guest moderators, as the handler for "change:participantType"
events that shows and hides it in the public page is set during the UI
initialization, but it was removed when joining the room.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu
    danxuliu authored and Backportbot committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    f6358b5 View commit details
    Browse the repository at this point in the history