Do not remove other event handlers when setting the active room #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Besides being more correct, this also fixes the participant list not shown for guest moderators, as the handler for "change:participantType" events that shows and hides it in the public page is set during the UI initialization, but it was removed when joining the room. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
/backport to stable17 |
delete-merged-branch
bot
deleted the
do-not-remove-other-event-handlers-when-setting-the-active-room
branch
|
backport to stable17 in #2230 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #1926 (specifically, 0ab60ec)
How to test
Result with this pull request
The participant list is shown for the guest.
Result without this pull request
The participant list is not shown for the guest (although the moderation menu is).