Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read only conversations #1640

Merged
merged 11 commits into from
Mar 26, 2019
Merged

Read only conversations #1640

merged 11 commits into from
Mar 26, 2019

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 19, 2019 •
edited
Loading

The UI does currently not reflect the state, nor allow to change it, but it is a pre-requirement for #1616

  • Add capability
  • Allow to set read-only state as moderator
  • Remove/disable chat input on read-only
  • Do not allow sending messages, starting call, … on the API
  • Remove/disable call button
  • Add system message
  • Do not allow to share files into read-only conversations
  • Raise an issue about the missing UI option: Add an UI option for "read-only" conversations #1647

Fix #383

@nickvergessen nickvergessen added 2. developing enhancement feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Mar 19, 2019
@nickvergessen nickvergessen added this to the 💚 Next Major milestone Mar 19, 2019
@nickvergessen nickvergessen mentioned this pull request Mar 19, 2019
Merged
6 tasks
@nickvergessen
Copy link
Member Author

Bildschirmfoto von 2019-03-20 10-14-58

@nickvergessen
Copy link
Member Author

And white with updated texts:

Bildschirmfoto von 2019-03-20 10-20-28

@nickvergessen nickvergessen force-pushed the feature/383/read-only-conversations branch 2 times, most recently from 736af74 to 575ada2 Compare March 20, 2019 13:03
@nickvergessen nickvergessen mentioned this pull request Mar 20, 2019
Closed
@nickvergessen
Copy link
Member Author

Ready to review @Ivansss

Ivansss
Ivansss approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

Ivansss
Ivansss requested changes Mar 21, 2019
View reviewed changes
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text input doesn't seem to recover when the room is unlocked

@nickvergessen
Copy link
Member Author

Seems the model is not linked correctly to the view, no idea. added to #1647

@nickvergessen nickvergessen force-pushed the feature/383/read-only-conversations branch from b87ca98 to 27ecdd0 Compare March 22, 2019 15:12
@nickvergessen
Copy link
Member Author

Sharing tests are fixed in #1654

@nickvergessen
Introduce a Read-Only state for conversations
f1667ac 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Move CallController to AEnvironmentAwareController and add "@RequireR…
c739c36 
…eadWriteConversation"

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Allow setting the read-only state of a room
695b757 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Disable the chat input and the call button for read-only conversations
37474c5 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add a system message when read-only state is changed
670a0f9 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Do not allow to share files into read-only conversations
e933569 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add integration tests for read-only conversations
9a8746d 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Check the correct property to generate system messages
57a6549 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix tests
d41faf0 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Correctly set the index of the messages in the array when a sytem mes…
9ba28e4 
…sage was killed

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix embedded.js ChatView
396bcc7 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feature/383/read-only-conversations branch from 27ecdd0 to 396bcc7 Compare March 25, 2019 14:17
@Ivansss Ivansss mentioned this pull request Mar 25, 2019
Merged
@nickvergessen nickvergessen merged commit ca6e9fe into master Mar 26, 2019
@nickvergessen nickvergessen deleted the feature/383/read-only-conversations branch March 26, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansss Ivansss Awaiting requested review from Ivansss

Assignees
No one assigned
Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @Ivansss