-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(email): Recognize guests invited via email #13499
Open
nickvergessen
wants to merge
14
commits into
main
Choose a base branch
from
feat/6098/recognize-email-invited-guests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
2. developing
enhancement
feature: api 🛠️
OCS API for conversations, chats and participants
feature: meetings 📅
Covering the webinary usecase incl. Lobby
feature: conversations 👥
labels
Oct 9, 2024
nickvergessen
force-pushed
the
feat/6098/recognize-email-invited-guests
branch
from
October 15, 2024 12:45
c2c1274
to
a673b3a
Compare
nickvergessen
commented
Oct 15, 2024
nickvergessen
commented
Oct 15, 2024
nickvergessen
commented
Oct 15, 2024
4 tasks
nickvergessen
force-pushed
the
feat/6098/recognize-email-invited-guests
branch
from
October 17, 2024 11:59
427e9fc
to
8a8f9b6
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
feat/6098/recognize-email-invited-guests
branch
from
October 18, 2024 15:08
a81cdfb
to
ed01b27
Compare
1 task
skalidindi53
approved these changes
Oct 18, 2024
nickvergessen
commented
Oct 18, 2024
lib/Service/BotService.php
Outdated
@@ -191,7 +191,7 @@ protected function sendAsyncRequest(BotServer $botServer, array $body, ?string $ | |||
]; | |||
|
|||
$data = [ | |||
'verify' => $this->certificateManager->getAbsoluteBundlePath(), | |||
'verify' => false,// $this->certificateManager->getAbsoluteBundlePath(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was not intentional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
enhancement
feature: api 🛠️
OCS API for conversations, chats and participants
feature: conversations 👥
feature: meetings 📅
Covering the webinary usecase incl. Lobby
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🛠️ API Checklist
🚧 Tasks
actorType = Attendee::ACTOR_GUEST
while it should beparticipantType = Participant::GUEST || participantType = Participant::GUEST_MODERATOR
?🏁 Checklist
docs/
has been updated or is not required