Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: archive conversations (frontend) #13358

Merged
merged 3 commits into from
Oct 11, 2024
Merged

feat: archive conversations (frontend) #13358

merged 3 commits into from
Oct 11, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 20, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

A B
image image
image image

image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Sep 20, 2024
@Antreesy Antreesy self-assigned this Sep 20, 2024
@Antreesy Antreesy force-pushed the feat/noid/archive-conversations-frontend branch from 5538bee to a807cbc Compare September 20, 2024 09:40
Base automatically changed from feat/noid/archive-conversations to main September 20, 2024 09:41
@Antreesy Antreesy force-pushed the feat/noid/archive-conversations-frontend branch 2 times, most recently from 34392f4 to 1e76d5f Compare September 20, 2024 11:33
@Antreesy Antreesy marked this pull request as ready for review September 20, 2024 11:34
DorraJaouad
DorraJaouad reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality is good but a few notes about how we will implement it in LS.

src/utils/conversation.js Show resolved Hide resolved
src/store/conversationsStore.js Show resolved Hide resolved
src/store/conversationsStore.js Outdated Show resolved Hide resolved
src/components/LeftSidebar/LeftSidebar.vue Outdated Show resolved Hide resolved
src/components/LeftSidebar/LeftSidebar.vue Outdated Show resolved Hide resolved
@nickvergessen nickvergessen mentioned this pull request Sep 23, 2024
Open
@Antreesy
Copy link
Contributor Author

Antreesy commented Sep 23, 2024 •
edited
Loading

Short summary after the live discussion:

  • When archiving, change 'notifications level' -> direct only (if was wider)
  • When archiving, change 'should notify about call' -> false
  • remove an option from filter dropdown (footer button is always present on screen)
  • make 'leave conversation' a dialog with 'archive instead' option
  • capabilities check (when filtering too)
  • conversation settings dialog option (danger zone)

@nickvergessen
Copy link
Member

When archiving, change 'notifications level' -> direct only (if was wider)
When archiving, change 'should notify about call' -> false

I guess we should do this on API level?

@Antreesy
Copy link
Contributor Author

I guess we should do this on API level?

Makes sense

@Antreesy Antreesy force-pushed the feat/noid/archive-conversations-frontend branch 2 times, most recently from 970835e to 6498409 Compare September 24, 2024 08:55
@Antreesy Antreesy force-pushed the feat/noid/archive-conversations-frontend branch from 6498409 to 845ae7b Compare September 24, 2024 12:14
@Antreesy Antreesy force-pushed the feat/noid/archive-conversations-frontend branch from ee8bee2 to aa2f638 Compare October 1, 2024 12:41
DorraJaouad
DorraJaouad approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works good 🦅 , just a few comments on the UI.

src/components/LeftSidebar/ConversationsList/Conversation.vue Outdated Show resolved Hide resolved
src/components/ConversationSettings/ConversationSettingsDialog.vue Outdated
{{ t('spreed', 'Archive conversation') }}
</NcCheckboxRadioSwitch>
<p class="app-settings-section__hint">
{{ t('spreed', 'Archived conversations are hidden from the conversation list by default. They will still be shown, if you have been mentioned directly, when you search for the conversation name or filter your conversation list for archived conversations.') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{ t('spreed', 'Archived conversations are hidden from the conversation list by default. They will still be shown, if you have been mentioned directly, when you search for the conversation name or filter your conversation list for archived conversations.') }}
{{ t('spreed', 'Archived conversations are hidden from the conversation list by default. They will still be shown when you search for the conversation name or open archived conversations list.') }}

Because mentioning depends on user notification settings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping line for now to not create extra work for translators. Will continue in follow-up

src/components/LeftSidebar/ConversationsList/Conversation.vue Outdated Show resolved Hide resolved
@Antreesy
feat: add handling of archived conversations
0b2e981 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/noid/archive-conversations-frontend branch from aa2f638 to 1d19a6f Compare October 11, 2024 16:13
@Antreesy
feat: handle leave conversation via dialog
23da937 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
feat: add filtering of archived conversations
19286fd 
- show ongoing calls in archived conversations, if 'notify about calls' is truthy

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/noid/archive-conversations-frontend branch from 1d19a6f to 19286fd Compare October 11, 2024 16:28
@Antreesy Antreesy merged commit 1b288b7 into main Oct 11, 2024
46 checks passed
@Antreesy Antreesy deleted the feat/noid/archive-conversations-frontend branch October 11, 2024 16:32
@Antreesy Antreesy mentioned this pull request Oct 11, 2024
Open
6 tasks
@Antreesy
Copy link
Contributor Author

/backport to stable30

@backportbot backportbot bot mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@SystemKeeper SystemKeeper SystemKeeper left review comments

@ShGKme ShGKme ShGKme left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review enhancement feature: conversations 👥 feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
5 participants
@Antreesy @nickvergessen @SystemKeeper @ShGKme @DorraJaouad