Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable13] backport various scss fixes #8777 #9259

Merged
merged 1 commit into from
May 4, 2018
Merged

[stable13] backport various scss fixes #8777 #9259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions core/css/apps.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ kbd {
> a,
> .app-navigation-entry-bullet {
/* hide icon or bullet if loading state*/
background: none !important;
background: transparent !important;
}
}
/* Main entry link */
Expand Down Expand Up @@ -247,6 +247,11 @@ kbd {
border: none;
border-radius: 50%;
cursor: pointer;
transition: background 100ms ease-in-out;
+ a {
/* hide icon if bullet, can't have both */
background: transparent !important;
}
}

/* popover fix the flex positionning of the li parent */
Expand Down Expand Up @@ -303,7 +308,7 @@ kbd {
margin: 0;
z-index: 110;
}
&:after {
&:before {
position: absolute;
height: 44px;
width: 44px;
Expand All @@ -323,13 +328,14 @@ kbd {
-webkit-transform: rotate(-90deg);
-ms-transform: rotate(-90deg);
transform: rotate(-90deg);
z-index: 50;
}

/* force padding on link no matter if 'a' has an icon class */
> a:first-child {
padding-left: 44px;
}
&:after,
&:before,
> a {
transition: background 100ms ease-in-out,
transform 250ms ease-in-out,
Expand All @@ -341,7 +347,7 @@ kbd {
}
&:hover,
&:focus {
&:after {
&:before {
opacity: 1;
}
}
Expand Down