Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload button visible on read-only folders #8589

Merged
merged 1 commit into from
Feb 28, 2018

Commits on Feb 28, 2018

  1. Fix upload button visible on read-only folders

    The div that contains the elements related to the creation of new files,
    and thus the upload button, is always present in the DOM; it is hidden
    or shown based on the folder permissions by adding or removing the
    "hidden" CSS class. However, as the other CSS classes for the div are
    "actions" and "creatable" and a "display: flex" rule was defined for
    ".actions.creatable" below the "display: none" rule for
    ".actions.hidden" the last one took precedence and the div ended being
    always visible, even if the "hidden" CSS class was set. Now the rules
    for the ".actions.hidden" selector are defined below the rules for the
    ".actions.creatable" selector and thus the "display: none" rule is
    applied as expected.
    
    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    danxuliu committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    542dc2b View commit details
    Browse the repository at this point in the history