[stable12] Fix edit tag textbox size #8408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7586 Signed-off-by: Aastha Gupta <aastha.gupta4104@gmail.com>
MorrisJobke
approved these changes
Feb 17, 2018
Codecov Report
@@ Coverage Diff @@
## stable12 #8408 +/- ##
===========================================
Coverage 53.84% 53.84%
Complexity 22755 22755
===========================================
Files 1386 1386
Lines 87129 87129
Branches 1331 1331
===========================================
Hits 46915 46915
Misses 40214 40214
|
danxuliu
approved these changes
Feb 17, 2018
There was a problem hiding this comment.
Tested and works 👍
However, I have noticed that the final height of the input field is 32px instead of 30px; this is caused by the min-height rule applied to input elements in the server. Anyway, works for me ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #8376