Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleting folders when using s3 external storage #8100

Merged
merged 2 commits into from
Feb 8, 2018

Conversation

icewind1991
Copy link
Member

Fixes #7667

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 29, 2018
@icewind1991 icewind1991 added this to the Nextcloud 14 milestone Jan 29, 2018
@MorrisJobke
Copy link
Member

@wildlifechorus @schnaser @Flandoll Please help testing this :)

@codecov
Copy link

codecov bot commented Jan 29, 2018

Codecov Report

Merging #8100 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #8100      +/-   ##
===========================================
- Coverage      51.7%   51.7%   -0.01%     
- Complexity    25427   25428       +1     
===========================================
  Files          1598    1598              
  Lines         95239   95242       +3     
  Branches       1376    1376              
===========================================
  Hits          49244   49244              
- Misses        45995   45998       +3
Impacted Files Coverage Δ Complexity Δ
apps/files_external/lib/Lib/Storage/AmazonS3.php 0% <0%> (ø) 111 <0> (+1) ⬆️
lib/private/Server.php 85.24% <0%> (-0.1%) 281% <0%> (ø)
lib/private/Security/CertificateManager.php 92% <0%> (+1%) 39% <0%> (ø) ⬇️

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@MorrisJobke MorrisJobke merged commit 12c9bad into master Feb 8, 2018
@MorrisJobke MorrisJobke deleted the s3-folder-delete branch February 8, 2018 13:11
@MorrisJobke
Copy link
Member

I guess this needs to be backported tos table12/13?

@Disco1
Copy link

Disco1 commented Sep 22, 2019

I'm having the same issue. Trying to delete certain files and folders from S3 causes an error "unable to delete". There is nothing in the nextcloud.log that points to anything of interest. I have verified that the attached fix patch has been applied to my instance (newly downloaded). Any ideas?

@kesselb
Copy link
Contributor

kesselb commented Sep 22, 2019

@Disco1 would you mind to create a issue report https://github.com/nextcloud/server/issues/new?labels=bug%2C+0.+Needs+triage&template=Bug_report.md for this? This pull request is not the right place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to delete folder inside S3
5 participants