-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deleting folders when using s3 external storage #8100
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@wildlifechorus @schnaser @Flandoll Please help testing this :) |
Codecov Report
@@ Coverage Diff @@
## master #8100 +/- ##
===========================================
- Coverage 51.7% 51.7% -0.01%
- Complexity 25427 25428 +1
===========================================
Files 1598 1598
Lines 95239 95242 +3
Branches 1376 1376
===========================================
Hits 49244 49244
- Misses 45995 45998 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
I guess this needs to be backported tos table12/13? |
I'm having the same issue. Trying to delete certain files and folders from S3 causes an error "unable to delete". There is nothing in the nextcloud.log that points to anything of interest. I have verified that the attached fix patch has been applied to my instance (newly downloaded). Any ideas? |
@Disco1 would you mind to create a issue report https://github.com/nextcloud/server/issues/new?labels=bug%2C+0.+Needs+triage&template=Bug_report.md for this? This pull request is not the right place. |
Fixes #7667