Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] do not catch and ignore ServerNotAvailable in the wrong spot #8074

Merged
merged 1 commit into from
Jan 27, 2018

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jan 26, 2018

backport of #8069

might cause the user to be unavailable (race condition).

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added this to the Nextcloud 12.0.6 milestone Jan 26, 2018
@codecov
Copy link

codecov bot commented Jan 26, 2018

Codecov Report

Merging #8074 into stable12 will increase coverage by <.01%.
The diff coverage is 25%.

@@              Coverage Diff               @@
##             stable12    #8074      +/-   ##
==============================================
+ Coverage       53.84%   53.84%   +<.01%     
- Complexity      22760    22761       +1     
==============================================
  Files            1385     1385              
  Lines           87148    87150       +2     
  Branches         1331     1331              
==============================================
+ Hits            46926    46928       +2     
  Misses          40222    40222
Impacted Files Coverage Δ Complexity Δ
apps/user_ldap/lib/Access.php 18.15% <ø> (ø) 305 <0> (ø) ⬇️
apps/user_ldap/lib/User_LDAP.php 73.57% <25%> (-0.61%) 74 <0> (+1)
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)
core/js/js.js 61.94% <0%> (+0.11%) 0% <0%> (ø) ⬇️
lib/private/Server.php 84.8% <0%> (+0.12%) 121% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke merged commit bae874c into stable12 Jan 27, 2018
@MorrisJobke MorrisJobke deleted the stable12-8069 branch January 27, 2018 12:46
@MorrisJobke MorrisJobke mentioned this pull request Mar 9, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants