Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token polish #806

Merged
merged 5 commits into from
Aug 10, 2016
Merged

Token polish #806

merged 5 commits into from
Aug 10, 2016

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Aug 10, 2016

For #735

  • Added note that password is only shown once
  • Added clipboardjs to copy token directly
  • Can delete new token directly
  • If token is deleted before pressing done form is collapsed
  • Add sliding animation for hiding/showing of form/results

Before:
before

After:
after

CC: @MorrisJobke @schiessle @jancborchardt @ChristophWurst @LukasReschke

@rullzer rullzer added 3. to review Waiting for reviews backport-request labels Aug 10, 2016
@rullzer rullzer added this to the Nextcloud 11.0 milestone Aug 10, 2016
@mention-bot
Copy link

@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ChristophWurst, @jancborchardt and @icewind1991 to be potential reviewers

@MorrisJobke MorrisJobke mentioned this pull request Aug 10, 2016
67 tasks
@ChristophWurst
Copy link
Member

@jancborchardt how about we make the input field a bit wider and put the clipboard-js icon into it, like with the login button on the login screen?

@schiessle
Copy link
Member

@ChristophWurst sounds like a good idea. But we should unify this, so that it looks everywhere the same.

@rullzer
Copy link
Member Author

rullzer commented Aug 10, 2016

I'm all for it but lets do that separatly against master so we can get this in and backported.

@MorrisJobke
Copy link
Member

I tested this and it works fine. I only added a bit more margin between copy icon and "Done" button to have it look nicer.

@MorrisJobke
Copy link
Member

👍

@MorrisJobke
Copy link
Member

bildschirmfoto 2016-08-10 um 10 49 14

@LukasReschke
Copy link
Member

LGTM

@LukasReschke LukasReschke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 10, 2016
@rullzer rullzer merged commit cdb574c into master Aug 10, 2016
@rullzer rullzer deleted the token_polish branch August 10, 2016 10:12
@rullzer rullzer mentioned this pull request Aug 10, 2016
@jancborchardt
Copy link
Member

Nice, good stuff @rullzer @MorrisJobke 🚀

GitHubUser4234 pushed a commit to GitHubUser4234/server that referenced this pull request Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants