-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token polish #806
Token polish #806
Conversation
* Always show delete icon * Hide form if the new icon is deleted
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ChristophWurst, @jancborchardt and @icewind1991 to be potential reviewers |
@jancborchardt how about we make the input field a bit wider and put the clipboard-js icon into it, like with the login button on the login screen? |
@ChristophWurst sounds like a good idea. But we should unify this, so that it looks everywhere the same. |
I'm all for it but lets do that separatly against master so we can get this in and backported. |
I tested this and it works fine. I only added a bit more margin between copy icon and "Done" button to have it look nicer. |
👍 |
LGTM |
Nice, good stuff @rullzer @MorrisJobke 🚀 |
For #735
Before:
After:
CC: @MorrisJobke @schiessle @jancborchardt @ChristophWurst @LukasReschke