Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the type hints of migrations and correctly inject the wrapped sch… #7915

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

nickvergessen
Copy link
Member

…ema into migrations

Backport #7909

…ema into migrations

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Jan 17, 2018
@nickvergessen nickvergessen added this to the Nextcloud 13 milestone Jan 17, 2018
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 17, 2018
@codecov
Copy link

codecov bot commented Jan 17, 2018

Codecov Report

Merging #7915 into stable13 will not change coverage.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             stable13    #7915   +/-   ##
===========================================
  Coverage       51.23%   51.23%           
  Complexity      24972    24972           
===========================================
  Files            1607     1607           
  Lines           95027    95027           
  Branches         1376     1376           
===========================================
  Hits            48683    48683           
  Misses          46344    46344
Impacted Files Coverage Δ Complexity Δ
...es/lib/Migration/Version1002Date20170919123342.php 0% <ø> (ø) 2 <0> (ø) ⬇️
core/Command/Db/Migrations/GenerateCommand.php 0% <ø> (ø) 13 <0> (ø) ⬇️
lib/public/Migration/BigIntMigration.php 0% <ø> (ø) 4 <0> (ø) ⬇️
...av/lib/Migration/Version1004Date20170919104507.php 0% <ø> (ø) 1 <0> (ø) ⬇️
...es/lib/Migration/Version1002Date20170926101419.php 0% <ø> (ø) 1 <0> (ø) ⬇️
...av/lib/Migration/Version1004Date20170924124212.php 0% <ø> (ø) 1 <0> (ø) ⬇️
core/Migrations/Version13000Date20170705121758.php 0% <ø> (ø) 3 <0> (ø) ⬇️
...av/lib/Migration/Version1004Date20170926103422.php 0% <ø> (ø) 1 <0> (ø) ⬇️
...es/lib/Migration/Version1002Date20170607104347.php 0% <ø> (ø) 2 <0> (ø) ⬇️
core/Migrations/Version13000Date20170814074715.php 0% <ø> (ø) 4 <0> (ø) ⬇️
... and 9 more

@rullzer rullzer merged commit 414d6e2 into stable13 Jan 17, 2018
@rullzer rullzer deleted the backport/7909/fix-migration-type-hints branch January 17, 2018 13:55
@MorrisJobke MorrisJobke mentioned this pull request Jan 18, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants