[stable12] Fix password displayed as username in Firefox password manager dialog #7797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When finishing the setup of Nextcloud through the WebUI (setting admin user and database) Firefox offers to save the username and password. However, the password was shown in both the username and password fields of the Firefox password manager dialog. The problem was that the password input element (in the HTML form) is cloned in a text input element, which is used to show the password in plain text when clicking on the "Show password" button. As it was a text input immediately followed by a password input Firefox seemed to assume that it had to be the username and ignored the real username field, no matter the value set for the "autocomplete" attribute. Now the cloned text input is added after the password input, so Firefox no longer thinks that the cloned text input is the username field and the password manager dialog shows the proper username instead. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
To show the password in plain text "showPassword" adds a text input after the password input and swaps their visibility depending on whether the password has to be shown in plain text or not. In a similar way, "strengthify" by default adds the strength bar after the input element it was called on. Due to this, if "showPassword" is called before "strengthify" on the same password input then the strength bar ends between the password input and the text input, and when the text input is shown it appears below the strength bar. To fix this now the strength bar is added after the text input in those places in which "strengthify" was called after "showPassword" on the same element. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
Let's wait with this for 12.0.6 |
rullzer
approved these changes
Jan 24, 2018
|
12.0.6 is here! Review review review :) |
MorrisJobke
approved these changes
Jan 24, 2018
MorrisJobke
deleted the
stable12-7709-fix-password-displayed-as-username-in-password-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7709