Properly detect if fopen fails for txt previews #7453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
added
3. to review
rullzer
requested review from
MorrisJobke,
icewind1991,
ChristophWurst,
blizzz and
danxuliu
MorrisJobke
approved these changes
Dec 11, 2017
ChristophWurst
approved these changes
Dec 11, 2017
ChristophWurst
added
4. to release
Codecov Report
@@ Coverage Diff @@
## master #7453 +/- ##
============================================
- Coverage 51.08% 51.08% -0.01%
- Complexity 24869 24870 +1
============================================
Files 1596 1596
Lines 94628 94630 +2
Branches 1367 1367
============================================
+ Hits 48345 48346 +1
- Misses 46283 46284 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our sentry instance found 2 occurrences where apparently the fopen failed, no clue why it failed.. Better not to start throwing exceptions and just return false so we know no preview was generated.
easy one