-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix email buttons for white theme #7427
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
rullzer,
LukasReschke,
jancborchardt,
juliusknorr and
skjnldsv
December 8, 2017 11:18
cc @nextcloud/theming |
MorrisJobke
force-pushed
the
fix-white-color-in-emails
branch
from
December 8, 2017 11:25
b2c197f
to
40fff71
Compare
skjnldsv
approved these changes
Dec 8, 2017
We maybe should backport this to stable12. |
rullzer
approved these changes
Dec 11, 2017
Failing tests |
Fixed. |
MorrisJobke
force-pushed
the
fix-white-color-in-emails
branch
from
December 11, 2017 13:09
40fff71
to
41934d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #7427 +/- ##
============================================
- Coverage 50.97% 6.59% -44.39%
- Complexity 24735 24738 +3
============================================
Files 1586 1586
Lines 94257 94265 +8
Branches 1365 1365
============================================
- Hits 48049 6215 -41834
- Misses 46208 88050 +41842
|
MorrisJobke
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Dec 11, 2017
MorrisJobke
force-pushed
the
fix-white-color-in-emails
branch
from
December 11, 2017 13:22
41934d5
to
3af04e9
Compare
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
fix-white-color-in-emails
branch
from
December 11, 2017 13:34
3af04e9
to
cce4c28
Compare
This was referenced Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the theming app has set the color set to white the button in the emails where white with white text. This fixes that and introduces the
getTextColorPrimary
to the defaults interface to make the color calculation consistent.