Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't create sorter instances when none was requested #7324

Merged
merged 1 commit into from
Dec 11, 2017

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Nov 28, 2017

No description provided.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added 3. to review Waiting for reviews technical debt labels Nov 28, 2017
@blizzz blizzz added this to the Nextcloud 13 milestone Nov 28, 2017
@codecov
Copy link

codecov bot commented Nov 28, 2017

Codecov Report

Merging #7324 into master will increase coverage by <.01%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master    #7324      +/-   ##
============================================
+ Coverage     50.86%   50.86%   +<.01%     
- Complexity    24538    24539       +1     
============================================
  Files          1584     1584              
  Lines         93794    93795       +1     
  Branches       1358     1358              
============================================
+ Hits          47705    47706       +1     
  Misses        46089    46089
Impacted Files Coverage Δ Complexity Δ
core/Controller/AutoCompleteController.php 76.47% <83.33%> (+0.71%) 6 <0> (+1) ⬆️
apps/files_trashbin/lib/Expiration.php 90.32% <0%> (-1.62%) 29% <0%> (ø)
lib/private/Server.php 82.62% <0%> (-0.12%) 126% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️
lib/private/Security/CertificateManager.php 92.07% <0%> (+0.99%) 39% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke mentioned this pull request Dec 8, 2017
28 tasks
@rullzer rullzer merged commit c1fcd6f into master Dec 11, 2017
@rullzer rullzer deleted the no-sorters-no-instances branch December 11, 2017 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants