Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update login filter when user filter was newly generated #7321

Merged
merged 1 commit into from
Dec 8, 2017

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Nov 28, 2017

When the Login filter operates in assisted mode, changes to the user filter should also always trigger its update, because it utilizes it. It happens that admins forget to revisit the login filter which would trigger the update otherwise.

In manual mode, the login filter is not touched.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added 3. to review Waiting for reviews feature: ldap labels Nov 28, 2017
@blizzz blizzz added this to the Nextcloud 13 milestone Nov 28, 2017
@codecov
Copy link

codecov bot commented Nov 28, 2017

Codecov Report

Merging #7321 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7321      +/-   ##
============================================
+ Coverage     50.86%   50.86%   +<.01%     
  Complexity    24538    24538              
============================================
  Files          1584     1584              
  Lines         93794    93794              
  Branches       1358     1358              
============================================
+ Hits          47705    47706       +1     
+ Misses        46089    46088       -1
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/lib/Expiration.php 90.32% <0%> (-1.62%) 29% <0%> (ø)
lib/private/Server.php 82.62% <0%> (-0.12%) 126% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️
lib/private/Security/CertificateManager.php 92.07% <0%> (+0.99%) 39% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

@blizzz
Copy link
Member Author

blizzz commented Dec 7, 2017

ping?

@blizzz blizzz mentioned this pull request Dec 8, 2017
28 tasks
@LukasReschke LukasReschke merged commit bb8acc5 into master Dec 8, 2017
@MorrisJobke MorrisJobke deleted the ldap-update-loginfilter branch December 8, 2017 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants