Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flow #7115

Merged
merged 2 commits into from
Dec 8, 2017
Merged

Fix flow #7115

merged 2 commits into from
Dec 8, 2017

Conversation

mario
Copy link
Contributor

@mario mario commented Nov 8, 2017

Fixing issues found in #6879 + solved conflicts.

Signed-off-by: Mario Danic mario@lovelyhq.com

Signed-off-by: Mario Danic <mario@lovelyhq.com>
@blizzz blizzz added the 3. to review Waiting for reviews label Nov 13, 2017
@blizzz blizzz added this to the Nextcloud 13 milestone Nov 13, 2017
@blizzz
Copy link
Member

blizzz commented Nov 13, 2017

@LukasReschke

Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem to be failing.

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@codecov
Copy link

codecov bot commented Dec 8, 2017

Codecov Report

Merging #7115 into master will decrease coverage by 16.05%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             master    #7115       +/-   ##
=============================================
- Coverage     50.74%   34.68%   -16.06%     
- Complexity    24417    24419        +2     
=============================================
  Files          1580     1580               
  Lines         93342    93348        +6     
  Branches       1359     1359               
=============================================
- Hits          47366    32378    -14988     
- Misses        45976    60970    +14994
Impacted Files Coverage Δ Complexity Δ
core/Controller/ClientFlowLoginController.php 0% <0%> (-78.88%) 22 <0> (+2)
apps/dav/lib/CalDAV/Activity/Setting/Calendar.php 0% <0%> (-100%) 8% <0%> (ø)
lib/private/Hooks/ForwardingEmitter.php 0% <0%> (-100%) 5% <0%> (ø)
lib/public/AppFramework/Http/JSONResponse.php 0% <0%> (-100%) 5% <0%> (ø)
lib/public/AppFramework/Middleware.php 0% <0%> (-100%) 4% <0%> (ø)
core/Command/TwoFactorAuth/Disable.php 0% <0%> (-100%) 4% <0%> (ø)
...pFramework/Db/MultipleObjectsReturnedException.php 0% <0%> (-100%) 1% <0%> (ø)
...eLimiting/Exception/RateLimitExceededException.php 0% <0%> (-100%) 1% <0%> (ø)
apps/dav/lib/CalDAV/Activity/Setting/Event.php 0% <0%> (-100%) 8% <0%> (ø)
...ty/Exceptions/CrossSiteRequestForgeryException.php 0% <0%> (-100%) 1% <0%> (ø)
... and 501 more

@MorrisJobke MorrisJobke mentioned this pull request Dec 8, 2017
28 tasks
Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 6aac1ff into master Dec 8, 2017
@MorrisJobke MorrisJobke deleted the fix-flow branch December 8, 2017 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants