Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix login appearance for ios webkit engine #7111

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Fix login appearance for ios webkit engine #7111

merged 1 commit into from
Nov 8, 2017

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 8, 2017

Before After
bs_realios_mobile_iphone 6s-9 0 bs_realios_mobile_iphone 6s-9 0 1

@nextcloud/designers

@skjnldsv skjnldsv added 3. to review Waiting for reviews bug design Design, UI, UX, etc. low labels Nov 8, 2017
@skjnldsv skjnldsv added this to the Nextcloud 13 milestone Nov 8, 2017
@skjnldsv skjnldsv self-assigned this Nov 8, 2017
MorrisJobke
MorrisJobke approved these changes Nov 8, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
Copy link
Member

@skjnldsv Any reason why this only happens on master and not on stable12?

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 8, 2017

@MorrisJobke scss I guess :/

@LukasReschke LukasReschke merged commit f9d8eb2 into master Nov 8, 2017
@LukasReschke LukasReschke deleted the login-button-ios-f branch November 8, 2017 23:00
@rullzer rullzer mentioned this pull request Nov 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@LukasReschke LukasReschke LukasReschke approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@pixelipo pixelipo Awaiting requested review from pixelipo

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. low
Projects
None yet
Milestone
Nextcloud 13
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @MorrisJobke @LukasReschke