Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theming: theme flow redirection page #7110

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Theming: theme flow redirection page #7110

merged 1 commit into from
Nov 8, 2017

Conversation

juliusknorr
Copy link
Member

Fix for #7104

please review @nextcloud/theming

bildschirmfoto vom 2017-11-08 13-03-53

@juliusknorr juliusknorr added this to the Nextcloud 13 milestone Nov 8, 2017
@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2017

An example of how to get to this page?

@juliusknorr
Copy link
Member Author

You need to open index.php/login/flow with the OCS-APIREQUEST header set to "true" and click the button.

I use the ModHeader chrome extension to set custom header values.

@juliusknorr
Theming: theme flow redirection page
cd1bfea 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@codecov
Copy link

codecov bot commented Nov 8, 2017 •
edited
Loading

Codecov Report

Merging #7110 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #7110      +/-   ##
============================================
+ Coverage     50.73%   50.73%   +<.01%     
  Complexity    24415    24415              
============================================
  Files          1579     1579              
  Lines         93327    93327              
  Branches       1359     1359              
============================================
+ Hits          47347    47348       +1     
+ Misses        45980    45979       -1
Impacted Files Coverage Δ Complexity Δ
core/templates/loginflow/redirect.php 0% <ø> (ø) 0 <0> (ø) ⬇️
core/Controller/ClientFlowLoginController.php 78.87% <100%> (ø) 20 <0> (ø) ⬇️
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️

skjnldsv
skjnldsv approved these changes Nov 8, 2017
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly fine!

LukasReschke
LukasReschke approved these changes Nov 8, 2017
View reviewed changes
Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat :)

@LukasReschke LukasReschke merged commit d948626 into master Nov 8, 2017
@LukasReschke LukasReschke deleted the fix-flow-redirect branch November 8, 2017 16:45
@MorrisJobke MorrisJobke mentioned this pull request Nov 8, 2017
Merged
@MorrisJobke
Copy link
Member

Backport in #7114

@rullzer rullzer mentioned this pull request Nov 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@LukasReschke LukasReschke LukasReschke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: theming
Projects
None yet
Milestone
Nextcloud 13
Development

Successfully merging this pull request may close these issues.
5 participants
@juliusknorr @skjnldsv @MorrisJobke @rullzer @LukasReschke