Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for invalid bucket names #7076

Merged
merged 1 commit into from
Nov 6, 2017

Conversation

MorrisJobke
Copy link
Member

Found in my stashes and was from a debugging session for S3 bucket names. Makes also the code less static. 😉

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Nov 6, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Nov 6, 2017
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and changes make sense!

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sane :)

@MorrisJobke MorrisJobke merged commit 5ed0521 into master Nov 6, 2017
@MorrisJobke MorrisJobke deleted the s3-valid-bucket-name branch November 6, 2017 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants