Can not change encryption directory #6805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
1. to develop
nickvergessen
commented
Oct 10, 2017
| @@ -146,7 +146,7 @@ protected function prepareNewRoot($newRoot) { | |||
| 'ownCloud will detect this folder as key storage root only if this file exists' | |||
| ); | |||
|
|
|||
| if ($result === false) { | |||
| if ($result !== true) { | |||
There was a problem hiding this comment.
Currently the View returns null, because
server/lib/private/Files/View.php
Line 1103 in b9b88aa
returns false and therefor nothing is executed.
|
@schiessle Any news for this? Would be good to get it in. |
|
Let's move this to 14. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
schiessle
force-pushed
the
can-not-change-encryption-directory
branch
from
9c4baa0
to
9259b8a
Compare
Codecov Report
@@ Coverage Diff @@
## master #6805 +/- ##
=============================================
- Coverage 51.93% 35.09% -16.84%
Complexity 25418 25418
=============================================
Files 1609 1609
Lines 95329 95329
Branches 1378 1378
=============================================
- Hits 49506 33454 -16052
- Misses 45823 61875 +16052
|
schiessle
approved these changes
Mar 1, 2018
|
second reviewer needed |
|
👍 for not my code |
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6769
@schiessle there is an issue here
/../in pathsTherefor you can only change the root inside your data directory, but not move it out of it.
If that is intended, we should have this commit here and display a better error message