Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create activities for (un)publishing calendar events #6590

Merged
merged 3 commits into from
Dec 11, 2017
Merged

Create activities for (un)publishing calendar events #6590

merged 3 commits into from
Dec 11, 2017

Conversation

tcitworld
Copy link
Member

Creates corresponding activities whenever a calendar is (un)published.

@tcitworld
Copy link
Member Author

I wrote You published calendar {calendar} but maybe we could have the same as the files app : You shared Calendar {calendar} as public link.

@tcitworld tcitworld added this to the Nextcloud 13 milestone Sep 20, 2017
@nickvergessen
Copy link
Member

I would go for "shared as public link yeah

@tcitworld
Copy link
Member Author

In that case, there's a lot of wording to change in the calendar app too.

@georgehrke
Copy link
Member

I think we should go for You shared Calendar {calendar} as public link, because that's how it's called in the files app. We should rename the wording in the calendar app too I guess.

@georgehrke
Copy link
Member

@tcitworld Can you please change the wording accordingly? :)

@georgehrke
Copy link
Member

Failing test looks unrelated

@MorrisJobke MorrisJobke mentioned this pull request Dec 8, 2017
Merged
28 tasks
@MorrisJobke
Copy link
Member

Let me update the wording.

@codecov
Copy link

codecov bot commented Dec 11, 2017 •
edited
Loading

Codecov Report

Merging #6590 into master will decrease coverage by 23.02%.
The diff coverage is 10.52%.

@@              Coverage Diff              @@
##             master    #6590       +/-   ##
=============================================
- Coverage     51.07%   28.04%   -23.03%     
+ Complexity    24830    23526     -1304     
=============================================
  Files          1594     1437      -157     
  Lines         94485    78699    -15786     
  Branches       1365        0     -1365     
=============================================
- Hits          48256    22072    -26184     
- Misses        46229    56627    +10398
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CalDAV/Activity/Provider/Calendar.php 0% <0%> (ø) 65 <0> (+4) ⬆️
apps/dav/lib/AppInfo/Application.php 0% <0%> (-20.23%) 14 <0> (ø)
apps/dav/lib/CalDAV/CalDavBackend.php 0% <0%> (-84.22%) 244 <0> (ø)
apps/dav/lib/CalDAV/Activity/Backend.php 26.02% <100%> (+4.02%) 67 <2> (+2) ⬆️
lib/private/Files/Mount/CacheMountProvider.php 0% <0%> (-100%) 4% <0%> (ø)
apps/admin_audit/composer/autoload.php 0% <0%> (-100%) 0% <0%> (ø)
apps/dav/lib/CalDAV/PublicCalendarRoot.php 0% <0%> (-100%) 4% <0%> (ø)
apps/dav/lib/Connector/Sabre/Server.php 0% <0%> (-100%) 1% <0%> (ø)
apps/files_versions/lib/Command/Expire.php 0% <0%> (-100%) 3% <0%> (ø)
apps/user_ldap/lib/Migration/UUIDFixGroup.php 0% <0%> (-100%) 1% <0%> (ø)
... and 832 more

MorrisJobke
MorrisJobke approved these changes Dec 11, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

rullzer
rullzer approved these changes Dec 11, 2017
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish 2. developing Work in progress and removed 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish labels Dec 11, 2017
@rullzer
Copy link
Member

rullzer commented Dec 11, 2017

Failing tests

tcitworld and others added 2 commits December 11, 2017 16:28
@tcitworld @rullzer
Create activities for (un)publishing calendar events
4c32de2 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@MorrisJobke @rullzer
Update wording
c76c7a9 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@rullzer rullzer force-pushed the dav-create-activities-for-publishing branch from d8643cf to c76c7a9 Compare December 11, 2017 15:28
@rullzer
Fix tests
effde61 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Copy link
Member

rullzer commented Dec 11, 2017

Should be OK now but lets wait for CI to be nice and green

@tcitworld
Copy link
Member Author

Thx, missed bdb0265

@MorrisJobke
Copy link
Member

Tests pass -> merging.

@MorrisJobke MorrisJobke merged commit ba3c608 into master Dec 11, 2017
@MorrisJobke MorrisJobke deleted the dav-create-activities-for-publishing branch December 11, 2017 16:13
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Dec 11, 2017
@tcitworld tcitworld mentioned this pull request Jun 26, 2018
Closed
@nickvergessen nickvergessen mentioned this pull request Jul 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@georgehrke georgehrke Awaiting requested review from georgehrke

@schiessle schiessle Awaiting requested review from schiessle

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: activity and notification feature: dav
Projects
None yet
Milestone
Nextcloud 13
Development

Successfully merging this pull request may close these issues.
5 participants
@tcitworld @nickvergessen @georgehrke @MorrisJobke @rullzer