Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark hackery to not always disable CSRF for OCS controllers #656

Merged
merged 1 commit into from
Jul 29, 2016

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Jul 29, 2016

@LukasReschke as discussed.

@rullzer rullzer added 3. to review Waiting for reviews security labels Jul 29, 2016
@rullzer rullzer added this to the Nextcloud 11.0 milestone Jul 29, 2016
@mention-bot
Copy link

@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @LukasReschke and @BernhardPosselt to be potential reviewers

@rullzer rullzer mentioned this pull request Jul 29, 2016
5 tasks
@icewind1991
Copy link
Member

your future self would appreciate some explanation around the dark hackery 😄

@LukasReschke
Copy link
Member

That will do 👍

@icewind1991
Copy link
Member

👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 29, 2016
@rullzer rullzer merged commit b841d39 into master Jul 29, 2016
@MorrisJobke MorrisJobke deleted the ocs_controller_csrf branch July 30, 2016 07:53
GitHubUser4234 pushed a commit to GitHubUser4234/server that referenced this pull request Aug 30, 2016
Dark hackery to not always disable CSRF for OCS controllers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants