Fix uninitialized variable $this->params #6433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@william-p, thanks for your PR! By analyzing the history of the files in this pull request, we identified @butonic, @icewind1991 and @owncloud-bot to be potential reviewers. |
william-p
force-pushed
the
Fix_uninitialized_params
branch
from
dc28f2a
to
d44fe48
Compare
Codecov Report
@@ Coverage Diff @@
## master #6433 +/- ##
============================================
+ Coverage 30.64% 53.4% +22.76%
Complexity 22514 22514
============================================
Files 1407 1407
Lines 87083 87083
Branches 1329 1329
============================================
+ Hits 26685 46507 +19822
+ Misses 60398 40576 -19822
|
|
Humm sorry, my commit was signed, where i wrong ? |
MorrisJobke
approved these changes
Sep 10, 2017
The sign-off is missing - see https://github.com/nextcloud/server/blob/master/CONTRIBUTING.md#sign-your-work for details |
MorrisJobke
requested review from
rullzer,
nickvergessen,
LukasReschke and
icewind1991
nickvergessen
approved these changes
Sep 11, 2017
Signed-off-by: William Pain <pain.william@gmail.com>
william-p
force-pushed
the
Fix_uninitialized_params
branch
from
d44fe48
to
9a63ded
Compare
LukasReschke
approved these changes
Sep 11, 2017
|
Needs backporting to 12 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use directly $params for build correct cache key.