Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message on untrusted domain error page #5821

Merged
merged 1 commit into from
Jul 21, 2017

Conversation

MorrisJobke
Copy link
Member

Fixes #5347

Before the theming app theme was loaded on that error page but all assets were not loaded because of the trusted domain error. So this changes the theme to the default one if the domain is untrusted.

Fixes #5347

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me

@bertalanimre
Copy link

So how can I fix this on NextCloud 12? Just installed it with the latest downloadable package.

@dyabolik004
Copy link

i have Nextcloud 12.0.4 and in lib/private/Server.php there is already the fix but it continue to show up in the log file!

@veelo
Copy link

veelo commented Jan 17, 2018

Can confirm that "theming.Theming.getLogo" errors are still in the log. Also, I notice that the e-mail sent out to welcome a new user has a missing logo. Different issue?

Symfony\Component\Routing\Exception\RouteNotFoundException: Unable to generate a URL for the named route "theming.Theming.getLogo" as such route does not exist.
/var/www/nextcloud/lib/private/Route/Router.php - line 339: Symfony\Component\Routing\Generator\UrlGenerator->generate('theming.Theming...', Array, 1)
/var/www/nextcloud/lib/private/Route/CachingRouter.php - line 60: OC\Route\Router->generate('theming.Theming...', Array, false)
/var/www/nextcloud/lib/private/URLGenerator.php - line 77: OC\Route\CachingRouter->generate('theming.Theming...', Array)
/var/www/nextcloud/apps/theming/lib/ThemingDefaults.php - line 165: OC\URLGenerator->linkToRoute('theming.Theming...')
/var/www/nextcloud/lib/public/Defaults.php - line 186: OCA\Theming\ThemingDefaults->getLogo(true)
/var/www/nextcloud/core/templates/layout.guest.php - line 45: OCP\Defaults->getLogo()
/var/www/nextcloud/lib/private/Template/Base.php - line 176: include('/var/www/nextcl...')
/var/www/nextcloud/lib/private/Template/Base.php - line 151: OC\Template\Base->load('/var/www/nextcl...', NULL)
/var/www/nextcloud/lib/private/legacy/template.php - line 202: OC\Template\Base->fetchPage(NULL)
/var/www/nextcloud/lib/private/legacy/template.php - line 224: OC_Template->fetchPage()
/var/www/nextcloud/lib/private/Template/Base.php - line 132: OC_Template->fetchPage()
/var/www/nextcloud/core/templates/403.php - line 7: OC\Template\Base->printPage(){main}

@MorrisJobke
Copy link
Member Author

Yes - please open new tickets for those errors.

@veelo
Copy link

veelo commented Jan 18, 2018

I will have to investigate further how to reproduce the exceptions. The missing logo in the e-mail is not a bug, it's due to Micosoft Mail being unale to render SVG :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants