-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error message on untrusted domain error page #5821
Conversation
Fixes #5347 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine by me
So how can I fix this on NextCloud 12? Just installed it with the latest downloadable package. |
i have Nextcloud 12.0.4 and in lib/private/Server.php there is already the fix but it continue to show up in the log file! |
Can confirm that "theming.Theming.getLogo" errors are still in the log. Also, I notice that the e-mail sent out to welcome a new user has a missing logo. Different issue?
|
Yes - please open new tickets for those errors. |
I will have to investigate further how to reproduce the exceptions. The missing logo in the e-mail is not a bug, it's due to Micosoft Mail being unale to render SVG :-/ |
Fixes #5347
Before the theming app theme was loaded on that error page but all assets were not loaded because of the trusted domain error. So this changes the theme to the default one if the domain is untrusted.