-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't create activities for email and password change before login #5508
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke to be a potential reviewer. |
@@ -78,7 +78,8 @@ public function __construct(IActivityManager $activityManager, | |||
public function onChangePassword($uid) { | |||
$user = $this->userManager->get($uid); | |||
|
|||
if (!$user instanceof IUser || $user->getEMailAddress() === null) { | |||
if (!$user instanceof IUser || $user->getLastLogin() === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still keep the email address is null, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, just because the user doesnt have an email, doesnt mean we should not create an activity...
This was basically an accident, because st first there were only emails and i forgot to remove it when adding activities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and worked 👍
Signed-off-by: Joas Schilling coding@schilljs.com