[stable12] Use realpath to obtain the webroot #5507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use realpath to obtain the webroot - backport Signed-off-by: Sebastian Kostka sebastian.kostka@gmail.com
|
Please review @MorrisJobke |
MorrisJobke
requested review from
nickvergessen,
MorrisJobke,
LukasReschke,
blizzz,
juliusknorr and
skjnldsv
MorrisJobke
approved these changes
Jun 22, 2017
juliusknorr
approved these changes
Jun 22, 2017
|
@derkostka This commit needs a sign off message as well 😉 Little tip for the next time backporting, after creating a new branch from the stable branch you can use |
MorrisJobke
added
4. to release
|
Thank you for the hint, i am just getting used to Git / Github. There is a sign off message ? Is it at the wrong location ? |
|
@derkostka Ah I missed that, I guess CI complains because you forgot to wrap your email in < > |
Fine anyways ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use realpath to obtain the webroot - backport of #5252
Signed-off-by: Sebastian Kostka sebastian.kostka@gmail.com