OCS correctly handle login exception #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @SergioBertolinSG, @DeepDiver1975 and @PVince81 to be potential reviewers |
|
👍 |
| @@ -85,6 +85,8 @@ | |||
| OC_Response::setStatus(405); | |||
| } catch (\OC\OCS\Exception $ex) { | |||
| OC_API::respond($ex->getResult(), OC_API::requestedFormat()); | |||
| } catch (\OC\User\LoginException $e) { | |||
| OC_API::respond(new OC_OCS_Result(null, \OCP\API::RESPOND_UNAUTHORISED, 'Unauthorised')); | |||
There was a problem hiding this comment.
The class OC_OCS_Result has been deprecated with message: Since 9.1.0 use \OC\OCS\Result
There was a problem hiding this comment.
I know but old obsolete api OC_API.
So I can't pass in \OC\OCS\Result
rullzer
force-pushed
the
ocs_correct_login_exception
branch
from
f623e3d
to
67ce87d
Compare
|
👍 |
MorrisJobke
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed case
Basically when a login exception is thrown (bad token/password/disabled user) we should repond with the proper OCS code.
CC: @LukasReschke