Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the file sharing app to migration #4812

Merged
merged 2 commits into from
May 18, 2017
Merged

Conversation

nickvergessen
Copy link
Member

  • Move existing update code to repair step
  • Fix migrating from OC to NC

@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @rullzer and @LukasReschke to be potential reviewers.

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@codecov
Copy link

codecov bot commented May 12, 2017

Codecov Report

Merging #4812 into master will decrease coverage by 22.84%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             master    #4812       +/-   ##
=============================================
- Coverage     54.19%   31.35%   -22.85%     
+ Complexity    22149    22135       -14     
=============================================
  Files          1363     1363               
  Lines         84820    84093      -727     
  Branches       1322     1322               
=============================================
- Hits          45966    26364    -19602     
- Misses        38854    57729    +18875
Impacted Files Coverage Δ Complexity Δ
.../files_sharing/lib/Migration/SetPasswordColumn.php 0% <0%> (ø) 6 <6> (?)
...s_sharing/lib/Migration/OwncloudGuestShareType.php 0% <0%> (ø) 6 <6> (?)
lib/private/SystemTag/ManagerFactory.php 0% <0%> (-100%) 3% <0%> (ø)
lib/public/Comments/CommentsEvent.php 0% <0%> (-100%) 3% <0%> (ø)
...s/dav/lib/Connector/Sabre/Exception/FileLocked.php 0% <0%> (-100%) 3% <0%> (ø)
apps/user_ldap/lib/Settings/Admin.php 0% <0%> (-100%) 5% <0%> (ø)
lib/private/Share20/Hooks.php 0% <0%> (-100%) 3% <0%> (ø)
lib/private/Repair/NC11/FixMountStorages.php 0% <0%> (-100%) 5% <0%> (ø)
apps/user_ldap/lib/Mapping/UserMapping.php 0% <0%> (-100%) 1% <0%> (ø)
...public/AppFramework/OCS/OCSBadRequestException.php 0% <0%> (-100%) 1% <0%> (ø)
... and 364 more

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do the job.
👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants