fix(BaseResponse): Cast XML element values to string #48013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
miaulalala,
a team,
ArtificialOwl,
artonge and
come-nc
and removed request for
a team
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
fix/baseresponse/xml-element-value-string-cast
branch
from
ec7fcce
to
3d9b498
Compare
sorbaugh
approved these changes
Sep 15, 2024
miaulalala
approved these changes
Sep 15, 2024
provokateurin
deleted the
fix/baseresponse/xml-element-value-string-cast
branch
This was referenced Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference: #47984
Summary
writeElement() only accepts ?string, so we need to cast it explicitly as it will fail with strict types enforced.
Checklist