Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppFramework default response for OCS is xml #480

Merged
merged 1 commit into from
Jul 21, 2016

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Jul 20, 2016

The OCSResponse differs from other responses in that it defaults to
XML. However we fell back to json by default.

This makes sure that if nothing is set we don't pass anything.
Which defaults then to the controllers default (which is often 'json')
but in the case of the OCSResponse 'xml'.

CC: @LukasReschke @BernhardPosselt @MorrisJobke

The OCSResponse differs from other responses in that it defaults to
XML. However we fell back to json by default.

This makes sure that if nothing is set we don't pass anything.
Which defaults then to the controllers default (which is often 'json')
but in the case of the OCSResponse 'xml'.
@rullzer rullzer added the 3. to review Waiting for reviews label Jul 20, 2016
@rullzer rullzer added this to the Nextcloud Next milestone Jul 20, 2016
@mention-bot
Copy link

@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @BernhardPosselt, @DeepDiver1975 and @MorrisJobke to be potential reviewers

@rullzer rullzer mentioned this pull request Jul 20, 2016
5 tasks
@rullzer rullzer changed the title AppFramework do not get default response AppFramework default response for OCS is xml Jul 20, 2016
@nickvergessen
Copy link
Member

👍

1 similar comment
@LukasReschke
Copy link
Member

👍

@LukasReschke LukasReschke merged commit 562e63c into master Jul 21, 2016
@LukasReschke LukasReschke deleted the fix_ocs_response_format branch July 21, 2016 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants