Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using partial file info as valid one #46672

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 22, 2024

  • fix: Ignore preview requests for invalid file ids
  • fix: Do not return partial file info if we have a cache entry
  • Resolves: #

Summary

This introduces a fix for object storage where partial file info could have lead to using 0 as a file id for partial files. In addition the second commit will make sure that instead of the partial one if we have (which is always the case with object storage as we create the file info before writing to storage).

Checklist

@juliusknorr juliusknorr requested review from icewind1991, Altahrim, a team and yemkareems and removed request for a team July 22, 2024 09:39
@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Jul 22, 2024
@juliusknorr juliusknorr added this to the Nextcloud 30 milestone Jul 22, 2024
@juliusknorr juliusknorr force-pushed the fix/preview-invalid-id branch 3 times, most recently from 0125534 to d86976c Compare July 22, 2024 11:41
@juliusknorr
Copy link
Member Author

/backport to stable29

@juliusknorr
Copy link
Member Author

/backport to stable28

@juliusknorr
Copy link
Member Author

/backport to stable27

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants